Skip to content

server: honor listall param for listiso api - #9064

Merged
shwstppr merged 1 commit into
apache:4.19from
shapeblue:fix-listiso-listall
May 28, 2024
Merged

server: honor listall param for listiso api#9064
shwstppr merged 1 commit into
apache:4.19from
shapeblue:fix-listiso-listall

Conversation

@shwstppr

@shwstppr shwstppr commented May 9, 2024

Copy link
Copy Markdown
Contributor

Description

Fixes #8315

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

@shwstppr
server: honor listall param for listiso api
4229c49 
Fixes apache#8315

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
@codecov-commenter

codecov-commenter commented May 9, 2024 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 14.96%. Comparing base (87e7c57) to head (4229c49).
Report is 3 commits behind head on 4.19.

Files Patch % Lines
...ain/java/com/cloud/api/query/QueryManagerImpl.java 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##               4.19    #9064      +/-   ##
============================================
- Coverage     14.96%   14.96%   -0.01%     
+ Complexity    10995    10990       -5     
============================================
  Files          5373     5373              
  Lines        469005   469024      +19     
  Branches      58953    59317     +364     
============================================
- Hits          70198    70193       -5     
- Misses       391036   391060      +24     
  Partials       7771     7771
Flag Coverage Δ
uitests 4.31% <ø> (ø)
unittests 15.67% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

sureshanaparti
sureshanaparti approved these changes May 9, 2024
View reviewed changes

@sureshanaparti sureshanaparti left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm

@sureshanaparti sureshanaparti added this to the 4.19.1.0 milestone May 9, 2024
@sureshanaparti

sureshanaparti commented May 9, 2024

Copy link
Copy Markdown
Contributor

@blueorangutan package

@blueorangutan

blueorangutan commented May 9, 2024

Copy link
Copy Markdown

@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

vishesh92
vishesh92 approved these changes May 9, 2024
View reviewed changes

@vishesh92 vishesh92 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@blueorangutan

blueorangutan commented May 9, 2024

Copy link
Copy Markdown

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9585

@DaanHoogland

DaanHoogland commented May 18, 2024

Copy link
Copy Markdown
Contributor

@blueorangutan test

@blueorangutan

blueorangutan commented May 18, 2024

Copy link
Copy Markdown

@DaanHoogland a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

@blueorangutan

blueorangutan commented May 18, 2024

Copy link
Copy Markdown

[SF] Trillian Build Failed (tid-10212)

@shwstppr

shwstppr commented May 22, 2024

Copy link
Copy Markdown
Contributor Author

@blueorangutan package

@blueorangutan

blueorangutan commented May 22, 2024

Copy link
Copy Markdown

@shwstppr a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan

blueorangutan commented May 22, 2024

Copy link
Copy Markdown

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9657

DaanHoogland
DaanHoogland approved these changes May 22, 2024
View reviewed changes

@DaanHoogland DaanHoogland left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm

@DaanHoogland

DaanHoogland commented May 22, 2024

Copy link
Copy Markdown
Contributor

@blueorangutan test

@blueorangutan

blueorangutan commented May 22, 2024

Copy link
Copy Markdown

@DaanHoogland a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

@blueorangutan

blueorangutan commented May 23, 2024

Copy link
Copy Markdown

[SF] Trillian test result (tid-10250)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 52554 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9064-t10250-kvm-centos7.zip
Smoke tests completed. 127 look OK, 4 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File
test_01_events_resource Error 405.91 test_events_resource.py
test_08_arping_in_ssvm Failure 5.22 test_diagnostics.py
test_09_arping_in_cpvm Failure 5.27 test_diagnostics.py
test_02_trigger_shutdown Failure 346.84 test_safe_shutdown.py
test_01_redundant_vpc_site2site_vpn Failure 410.44 test_vpc_vpn.py

@shwstppr

shwstppr commented May 27, 2024

Copy link
Copy Markdown
Contributor Author

@blueorangutan package

@blueorangutan

blueorangutan commented May 27, 2024

Copy link
Copy Markdown

@shwstppr a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan

blueorangutan commented May 27, 2024

Copy link
Copy Markdown

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9710

@shwstppr

shwstppr commented May 27, 2024

Copy link
Copy Markdown
Contributor Author

@blueorangutan test

@blueorangutan

blueorangutan commented May 27, 2024

Copy link
Copy Markdown

@shwstppr a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

@blueorangutan

blueorangutan commented May 27, 2024

Copy link
Copy Markdown

[SF] Trillian test result (tid-10284)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 47567 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9064-t10284-kvm-centos7.zip
Smoke tests completed. 130 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File
test_02_trigger_shutdown Failure 341.65 test_safe_shutdown.py

@shwstppr

shwstppr commented May 28, 2024

Copy link
Copy Markdown
Contributor Author

listIsos now return all ISOs when listall is passed,

(local) 🐱 > list isos filter=id,name,ispublic,domainid
{
  "count": 3,
  "iso": [
    {
      "domainid": "8da34656-08a3-11ef-9779-1e00a7000c5f",
      "id": "79681074-a7bd-4434-befd-e7c5ad728ee7",
      "ispublic": false,
      "name": "test1"
    },
    {
      "domainid": "8da34656-08a3-11ef-9779-1e00a7000c5f",
      "id": "fdeb66bc-57ac-491d-b4d8-c6a2545e064c",
      "ispublic": false,
      "name": "test1-dd"
    },
    {
      "domainid": "8da34656-08a3-11ef-9779-1e00a7000c5f",
      "id": "77c5f629-4e8c-4b04-8fa2-5b08e4a4d8d7",
      "ispublic": false,
      "name": "ds"
    }
  ]
}
(local) 🐱 > list isos filter=id,name,ispublic,domainid listall=true
{
  "count": 9,
  "iso": [
    {
      "domainid": "8da34656-08a3-11ef-9779-1e00a7000c5f",
      "id": "6c519636-3b2f-419c-b5bb-baac2c42ee5d",
      "ispublic": true,
      "name": "vmware-tools.iso"
    },
    {
      "domainid": "8da34656-08a3-11ef-9779-1e00a7000c5f",
      "id": "afa5ca21-6bd1-4682-88bc-c0956606250e",
      "ispublic": true,
      "name": "xs-tools.iso"
    },
    {
      "domainid": "8da34656-08a3-11ef-9779-1e00a7000c5f",
      "id": "aa621e5c-0689-412f-8b43-5976acdb404e",
      "ispublic": true,
      "name": "v1.26.0-Kubernetes-Binaries-ISO"
    },
    {
      "domainid": "8da34656-08a3-11ef-9779-1e00a7000c5f",
      "id": "79681074-a7bd-4434-befd-e7c5ad728ee7",
      "ispublic": false,
      "name": "test1"
    },
    {
      "domainid": "8da34656-08a3-11ef-9779-1e00a7000c5f",
      "id": "fdeb66bc-57ac-491d-b4d8-c6a2545e064c",
      "ispublic": false,
      "name": "test1-dd"
    },
    {
      "domainid": "8da34656-08a3-11ef-9779-1e00a7000c5f",
      "id": "77c5f629-4e8c-4b04-8fa2-5b08e4a4d8d7",
      "ispublic": false,
      "name": "ds"
    },
    {
      "domainid": "8da34656-08a3-11ef-9779-1e00a7000c5f",
      "id": "0bb30117-d53a-45e8-b2f5-65c17e635ff1",
      "ispublic": true,
      "name": "v1.24.0-Kubernetes-Binaries-ISO"
    },
    {
      "domainid": "8da34656-08a3-11ef-9779-1e00a7000c5f",
      "id": "969111e5-c6f9-4d46-822f-31c7700ff4d3",
      "ispublic": true,
      "name": "v1.24.0-Kubernetes-Binaries-ISO"
    },
    {
      "domainid": "db8c37e6-1e90-409b-addb-f1d8a9f77ce2",
      "id": "ff67dfbe-1b2b-4dd2-9c7a-309d14a5fc37",
      "ispublic": true,
      "name": "test-domain-iso"
    }
  ]
}

@shwstppr
shwstppr merged commit 261530c into apache:4.19 May 28, 2024
@shwstppr
shwstppr deleted the fix-listiso-listall branch May 28, 2024 07:13
@shwstppr shwstppr mentioned this pull request May 28, 2024
Closed
DaanHoogland added a commit that referenced this pull request May 28, 2024
@DaanHoogland
Merge release branch 4.19 to main
f1c3d2c 
* 4.19:
  engine-schema: add removed columne for cloud.user_data, fix delete op (#9120)
  ui: fix create menu item access (#9104)
  server: honor listall param for listiso api (#9064)
  ui: add move to top/bottom for acl rules list (#9119)
  ui: fix columns for exportacls csv (#9118)
  ui: fix create network access in deploy vm wizard (#9117)
  UI: Add search filters (#9068)
dhslove pushed a commit to ablecloud-team/ablestack-cloud that referenced this pull request Jun 17, 2024
@shwstppr @dhslove
server: honor listall param for listiso api (apache#9064)
bbe562d 
Fixes apache#8315

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
dhslove pushed a commit to ablecloud-team/ablestack-cloud that referenced this pull request Jun 17, 2024
@DaanHoogland @dhslove
Merge release branch 4.19 to main
a88f395 
* 4.19:
  engine-schema: add removed columne for cloud.user_data, fix delete op (apache#9120)
  ui: fix create menu item access (apache#9104)
  server: honor listall param for listiso api (apache#9064)
  ui: add move to top/bottom for acl rules list (apache#9119)
  ui: fix columns for exportacls csv (apache#9118)
  ui: fix create network access in deploy vm wizard (apache#9117)
  UI: Add search filters (apache#9068)
@vishesh92 vishesh92 mentioned this pull request Jun 28, 2024
Merged
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yadvr yadvr yadvr approved these changes
@DaanHoogland DaanHoogland DaanHoogland approved these changes
@vishesh92 vishesh92 vishesh92 approved these changes
@sureshanaparti sureshanaparti sureshanaparti approved these changes

Assignees

No one assigned

Labels

None yet

Projects

No open projects
Apache CloudStack 4.19.1
Status: Done

Milestone

4.19.1.0

Development

Successfully merging this pull request may close these issues.

7 participants

@shwstppr @codecov-commenter @sureshanaparti @blueorangutan @DaanHoogland @yadvr @vishesh92